Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: address account nonce discrepancies mono #11045

Merged
merged 27 commits into from
Feb 8, 2024
Merged

feat: address account nonce discrepancies mono #11045

merged 27 commits into from
Feb 8, 2024

Conversation

natanasow
Copy link
Collaborator

Description:

Introduce clear rules for when to update an Ethereum transaction signer's nonce and a new field for externalising the nonce update in the record stream. This will help resolve issues where the Consensus nodes and the Mirror nodes are out of sync in regards to what the current value of an account's nonce is.

Specification:

  1. The nonce of a signer of an Ethereum transaction should be increased for all transactions that are executed in the EVM.
  2. Transactions that have reached consensus and are handled by the node but have failed additional validations performed by the node prior to being executed in the EVM should have no effect on the Ethereum transaction signer nonce.
  3. A new protobuf field in the record stream - signerNonce - should be populated by the node with the current value of the signer account nonce after executing the transaction. This value should be used by the Mirror nodes when importing record stream files.

Protobuf update:

Add a new protobuf field to contract_call_local.proto:

message ContractFunctionResult {
    
    [...]

    /**
     * If not null this field specifies what the value of the signer account nonce is post transaction execution. 
     * For transactions that don't update the signer nonce, this field should be null.
     */
    Int64Value signer_nonce = 15;
}

Services update:

  1. Move the signer nonce update to be right before this code block that starts the EVM:
  2. Populate the new protobuf field when externalizing the transaction.

Fixes: #9728

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@natanasow natanasow requested a review from a team January 18, 2024 18:50
@natanasow natanasow requested a review from a team as a code owner January 18, 2024 18:50
@natanasow natanasow marked this pull request as draft January 18, 2024 18:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Node: HAPI Test (Restart) Results

1 tests   1 ✔️  7m 4s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Node: HAPI Test (Node Death Reconnect) Results

1 tests   1 ✔️  7m 34s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Node: HAPI Test (Token) Results

189 tests   189 ✔️  19m 56s ⏱️
  13 suites      0 💤
  13 files        0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Node: HAPI Test (Crypto) Results

211 tests   211 ✔️  30m 10s ⏱️
  22 suites      0 💤
  22 files        0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Node: E2E Test Results

    1 files      1 suites   24m 40s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs  333 ✔️ 0 💤 0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Node: Unit Test Results

    2 285 files  ±  0      2 285 suites  ±0   2h 34m 19s ⏱️ - 2h 12m 46s
118 512 tests +30  118 458 ✔️ +30  54 💤 ±0  0 ❌ ±0 
127 029 runs  +30  126 975 ✔️ +30  54 💤 ±0  0 ❌ ±0 

Results for commit dbb8b4e. ± Comparison against base commit 2258784.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (8bda7b2) 62.99% compared to head (773113f) 62.99%.
Report is 2 commits behind head on develop.

Files Patch % Lines
.../app/service/mono/state/submerkle/EvmFnResult.java 73.33% 1 Missing and 3 partials ⚠️
...ce/mono/txns/ethereum/EthereumTransitionLogic.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop   #11045      +/-   ##
=============================================
- Coverage      62.99%   62.99%   -0.01%     
- Complexity     31082    31088       +6     
=============================================
  Files           3362     3363       +1     
  Lines         137674   137708      +34     
  Branches       14479    14479              
=============================================
+ Hits           86728    86746      +18     
- Misses         47248    47261      +13     
- Partials        3698     3701       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Node: HAPI Test (Misc) Results

430 tests   416 ✔️  47m 23s ⏱️
  74 suites    14 💤
  74 files        0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Node: HAPI Test (Smart Contract) Results

451 tests   448 ✔️  1h 10m 54s ⏱️
  52 suites      3 💤
  52 files        0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Node: HAPI Test (Time Consuming) Results

20 tests   20 ✔️  54m 10s ⏱️
  2 suites    0 💤
  2 files      0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Node: Integration Test Results

    5 files      5 suites   1h 5m 42s ⏱️
319 tests 319 ✔️ 0 💤 0 ❌
331 runs  331 ✔️ 0 💤 0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

@mustafauzunn mustafauzunn added the Limechain Work planned for the LimeChain team label Jan 23, 2024
stoqnkpL
stoqnkpL previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@stoqnkpL stoqnkpL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinker-michaelj
Copy link
Collaborator

The nonce of a signer of an Ethereum transaction should be increased for all transactions that are executed in the EVM.

What counts as "executed in the EVM"? As long as we could charge gas, it counts?

@natanasow
Copy link
Collaborator Author

The nonce of a signer of an Ethereum transaction should be increased for all transactions that are executed in the EVM.

What counts as "executed in the EVM"? As long as we could charge gas, it counts?

IMO "executed in the EVM" means that the transaction has reached that point and there are no other "blockers". The last validations between prechecks and "evm execution" is here. So, once the transaction reaches that point, we are safe to increase the signer's nonce because there are no other potential validations that could lead to increasing the nonce and not executing the transaction like it was before.
The previous implementation increases the nonce here which causes a nonce discrepancy between services and mirror node because if the transaction fails in any of these checks, the nonce in services will be incremented but no record file will be exported and the new signer's nonce will not be populated in the mirror node.
These are my thoughts and feel free to correct me if I misunderstood something of that.

@mhess-swl mhess-swl removed their request for review February 6, 2024 00:59
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2258784) 62.97% compared to head (dbb8b4e) 62.98%.

Files Patch % Lines
.../app/service/mono/state/submerkle/EvmFnResult.java 73.33% 1 Missing and 3 partials ⚠️
...ce/mono/txns/ethereum/EthereumTransitionLogic.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #11045   +/-   ##
==========================================
  Coverage      62.97%   62.98%           
- Complexity     31080    31090   +10     
==========================================
  Files           3369     3369           
  Lines         137783   137802   +19     
  Branches       14460    14464    +4     
==========================================
+ Hits           86768    86788   +20     
- Misses         47312    47313    +1     
+ Partials        3703     3701    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stoqnkpL
stoqnkpL previously approved these changes Feb 6, 2024
View reviewed changes
@natanasow
chore: add tests
11f6393 
Signed-off-by: nikolay <[email protected]>
@stefan-stefanooov stefan-stefanooov mentioned this pull request Feb 7, 2024
Closed
tinker-michaelj
tinker-michaelj approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @natanasow !

@natanasow natanasow merged commit 77d207f into develop Feb 8, 2024
49 of 50 checks passed
@natanasow natanasow deleted the 9728-address-account-nonce-discrepancies-mono branch February 8, 2024 06:46
@georgi-l95 georgi-l95 mentioned this pull request Feb 8, 2024
Closed
natanasow added a commit that referenced this pull request Feb 8, 2024
@natanasow @Ivo-Yankov
feat: address account nonce discrepancies mono (#11045)
66a3a36 
Signed-off-by: nikolay <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Co-authored-by: Ivo Yankov <[email protected]>
@natanasow natanasow mentioned this pull request Feb 8, 2024
Merged
2 tasks
@litt3 litt3 mentioned this pull request Feb 12, 2024
Closed
@konstantinabl konstantinabl mentioned this pull request Feb 16, 2024
Closed
anastasiya-kovaliova added a commit that referenced this pull request Feb 22, 2024
@anastasiya-kovaliova
Squashed commit of the following:
057c318 
commit fd7b0fa
Author: Miroslav Gatsanoga <[email protected]>
Date:   Fri Feb 16 07:18:48 2024 +0200

    fix: conditional records hollow account creation via internal transfer with max child records exceeded (#10631)

    Signed-off-by: Miroslav Gatsanoga <[email protected]>
    Signed-off-by: Michael Tinker <[email protected]>
    Signed-off-by: Valentin Tronkov <[email protected]>
    Co-authored-by: Michael Tinker <[email protected]>
    Co-authored-by: Valentin Tronkov <[email protected]>

commit 0bc20e0
Author: Lev Povolotsky <[email protected]>
Date:   Thu Feb 15 23:17:09 2024 -0500

    fix: fee charge token create tx and also transaction hashing (#11562)

    Signed-off-by: Lev Povolotsky <[email protected]>

commit de8023b
Author: Petar Tonev <[email protected]>
Date:   Thu Feb 15 22:41:18 2024 +0200

    fix: add legacy etx support before EIP155 (#11504)

commit 6182387
Author: Nikita Lebedev <[email protected]>
Date:   Thu Feb 15 22:27:01 2024 +0200

    test: add `revertedAutoCreationRollsBackEvenIfTopLevelSucceeds` to `LazyCreateThroughPrecompileSuite` and enable fuzzy-matching on it (#11131)

    Signed-off-by: Nikita Lebedev <[email protected]>

commit 256e6a1
Author: Nathan Klick <[email protected]>
Date:   Thu Feb 15 14:11:29 2024 -0600

    build: add new Gradle modules for the block node (#11552)

    Signed-off-by: Nathan Klick <[email protected]>

commit b18e0da
Author: Cody Littley <[email protected]>
Date:   Thu Feb 15 12:29:49 2024 -0600

    fix: make verifyAsync() a passthrough method to the executor service (#11547)

    Signed-off-by: Cody Littley <[email protected]>

commit c810e12
Author: Cody Littley <[email protected]>
Date:   Thu Feb 15 11:32:54 2024 -0600

    fix: reduce sync permit count (#11545)

    Signed-off-by: Cody Littley <[email protected]>

commit 879abb7
Author: Maxi Tartaglia <[email protected]>
Date:   Thu Feb 15 14:08:12 2024 -0300

    fix: 11540-ConcurrentTestSupportTest (#11541)

    Signed-off-by: mxtartaglia <[email protected]>

commit 2281cde
Author: Ivo Yankov <[email protected]>
Date:   Thu Feb 15 17:34:11 2024 +0200

    fix: Nonce Discrepancies in Modularization (#11074)

    Signed-off-by: nikolay <[email protected]>
    Signed-off-by: Ivo Yankov <[email protected]>
    Co-authored-by: nikolay <[email protected]>

commit 22b662b
Author: Austin Littley <[email protected]>
Date:   Thu Feb 15 10:29:48 2024 -0500

    feat: Create new status panel, and add to existing dashboards (#11533)

    Signed-off-by: Austin Littley <[email protected]>

commit b7cd09e
Author: Austin Littley <[email protected]>
Date:   Thu Feb 15 10:14:29 2024 -0500

    chore: remove event observer dispatcher (#11449)

    Signed-off-by: Austin Littley <[email protected]>

commit 5eeec8f
Author: Edward Wertz <[email protected]>
Date:   Thu Feb 15 09:09:08 2024 -0600

    refactor: return AddressBook from AddressBookRoster (#11511)

    Signed-off-by: Edward Wertz <[email protected]>

commit d11925b
Author: Stanimir Stoyanov <[email protected]>
Date:   Thu Feb 15 17:07:04 2024 +0200

    fix: Enable fuzzy matching for HRCPrecompileSuite (#11032)

    Signed-off-by: Stanimir Stoyanov <[email protected]>

commit 34bdf1f
Author: Maxi Tartaglia <[email protected]>
Date:   Thu Feb 15 11:15:18 2024 -0300

    chore: Add NotNull/Nullable annotations to Metrics module (#11532)

    Signed-off-by: mxtartaglia <[email protected]>

commit 601f92b
Author: Austin Littley <[email protected]>
Date:   Wed Feb 14 16:06:23 2024 -0500

    feat: use ordered soldering for PCES flush requests (#11451)

    Signed-off-by: Austin Littley <[email protected]>

commit 4ae42e0
Author: Ivo Yankov <[email protected]>
Date:   Wed Feb 14 22:23:38 2024 +0200

    fix: Enable fuzzy matching for ApproveAllowanceSuite (#10787)

    Signed-off-by: Ivo Yankov <[email protected]>
    Co-authored-by: Michael Tinker <[email protected]>

commit 4b9e356
Author: Ivan Malygin <[email protected]>
Date:   Wed Feb 14 14:00:42 2024 -0500

    fix: 11507 Temporary disabled a test  (#11517)

    Reviewed-by: Anthony Petrov <[email protected]>, Artem Ananev <[email protected]>
    Signed-off-by: Ivan Malygin <[email protected]>

commit 1df51ea
Author: Hendrik Ebbers <[email protected]>
Date:   Wed Feb 14 17:39:34 2024 +0100

    fix: Improvements for ConcurrentTestSupport (#11276)

    Signed-off-by: Hendrik Ebbers <[email protected]>
    Co-authored-by: Maxi Tartaglia <[email protected]>

commit d0efd42
Author: Valentin Tronkov <[email protected]>
Date:   Wed Feb 14 18:14:58 2024 +0200

    feat: Enhance storage (file) store dumper to handle modular representation (#11385)

    Signed-off-by: Valentin Tronkov <[email protected]>

commit 19cb54b
Author: Lev Povolotsky <[email protected]>
Date:   Wed Feb 14 11:03:36 2024 -0500

    fix: rbs calculation in modularize code (#11518)

    Signed-off-by: Lev Povolotsky <[email protected]>

commit edfbdc1
Author: Matt Hess <[email protected]>
Date:   Wed Feb 14 10:02:20 2024 -0600

    fix: 11320: Use num sigs instead of num keys in token mint fee (#11464)

    Signed-off-by: Matt Hess <[email protected]>

commit 17a0bc2
Author: Michael Tinker <[email protected]>
Date:   Tue Feb 13 20:37:34 2024 -0600

    chore: remove files with long names (#11512)

    Signed-off-by: Michael Tinker <[email protected]>

commit 4262396
Author: Iris Simon <[email protected]>
Date:   Tue Feb 13 21:03:45 2024 -0500

    fix: fixed IndexOutOfBoundsException (#11493)

    Signed-off-by: Iris Simon <[email protected]>

commit abb0a56
Author: Michael Tinker <[email protected]>
Date:   Tue Feb 13 17:27:51 2024 -0600

    chore: fix yahcli build, `activate-staking` bug (#11501)

    Signed-off-by: Michael Tinker <[email protected]>

commit 9902d20
Author: anthony-swirldslabs <[email protected]>
Date:   Tue Feb 13 14:17:13 2024 -0800

    feat: 11347: introduce ReconnectHalfMillionNodesBench (#11487)

    Signed-off-by: Anthony Petrov <[email protected]>

commit b19fdaf
Author: Ivan Malygin <[email protected]>
Date:   Tue Feb 13 17:05:40 2024 -0500

    fix: 11507 Temporary disabled tests to stabilize pipeline (#11509)

    Signed-off-by: Ivan Malygin <[email protected]>

commit bede9b5
Author: Edward Wertz <[email protected]>
Date:   Tue Feb 13 15:58:25 2024 -0600

    refactor: EventCreator compatible with AncientMode (#11499)

    Signed-off-by: Edward Wertz <[email protected]>

commit f3de036
Author: Edward Wertz <[email protected]>
Date:   Tue Feb 13 14:13:33 2024 -0600

    feat: Address stores X509Certificate (#11318)

    Signed-off-by: Edward Wertz <[email protected]>

commit 0b4aa8d
Author: Deyan Dimitrov <[email protected]>
Date:   Tue Feb 13 21:42:58 2024 +0200

    feat: scheduled txs mono signed state dumper (#11390)

    Signed-off-by: dikel <[email protected]>

commit 9f3bc0e
Author: Matt Hess <[email protected]>
Date:   Tue Feb 13 13:34:16 2024 -0600

    fix: Migration only sets node ID under specific condition (#11485)

    Signed-off-by: Matt Hess <[email protected]>
    Co-authored-by: Ivan Malygin <[email protected]>

commit 754250c
Author: Petar Tonev <[email protected]>
Date:   Tue Feb 13 21:28:53 2024 +0200

    fix: check throttle usage on committing changes  (#11064)

commit e0eef7e
Author: Michael Tinker <[email protected]>
Date:   Tue Feb 13 11:03:43 2024 -0600

    chore: use shorter contract names (#11491)

    Signed-off-by: Michael Tinker <[email protected]>
    Co-authored-by: Michael Heinrichs <[email protected]>

commit ac755d1
Author: Lazar Petrovic <[email protected]>
Date:   Tue Feb 13 14:35:57 2024 +0100

    fix: state sent to be saved twice (#11488)

    Signed-off-by: Lazar Petrovic <[email protected]>

commit 30e929d
Author: Jendrik Johannes <[email protected]>
Date:   Tue Feb 13 10:40:13 2024 +0100

    build: Gradle update and QoL improvements (#11443)

    Signed-off-by: Jendrik Johannes <[email protected]>

commit b74cab4
Author: Jendrik Johannes <[email protected]>
Date:   Tue Feb 13 10:38:49 2024 +0100

    build: add back '-XX:ActiveProcessorCount=6' to 'eet' (#11483)

    Signed-off-by: Jendrik Johannes <[email protected]>

commit 1871c0c
Author: Ivan Malygin <[email protected]>
Date:   Mon Feb 12 20:36:25 2024 -0500

    fix: 11496 Temporary disabled `VirtualPipelineTests.flushThrottle`  (#11497)

    Signed-off-by: Ivan Malygin <[email protected]>

commit 6ea8984
Author: Ivan Ivanov <[email protected]>
Date:   Mon Feb 12 16:07:38 2024 +0200

    test: 11134 -  Create hapi tests for extCode operations for system accounts (#11278)

    Signed-off-by: Ivan Ivanov <[email protected]>

commit 02382b6
Author: Ivo Yankov <[email protected]>
Date:   Mon Feb 12 16:06:11 2024 +0200

    fix: Enable tests from Issue2319Spec (#10975)

    Signed-off-by: Ivo Yankov <[email protected]>

commit bb0357b
Author: Lazar Petrovic <[email protected]>
Date:   Mon Feb 12 11:56:31 2024 +0100

    chore: add debug info (#11473)

    Signed-off-by: Lazar Petrovic <[email protected]>

commit 98d1e45
Author: Cody Littley <[email protected]>
Date:   Fri Feb 9 14:20:32 2024 -0600

    fix: revert gossip birth round refactor (#11482)

commit 3892609
Author: Ivan Malygin <[email protected]>
Date:   Fri Feb 9 14:11:29 2024 -0500

    fix: 11472 Added @tag(TIMING_SENSITIVE) to the tests to stabilize the test pipeline. (#11475)

    Signed-off-by: Ivan Malygin <[email protected]>

commit 00d855a
Author: Cody Littley <[email protected]>
Date:   Fri Feb 9 11:35:20 2024 -0600

    fix: mark scheduler tests as timing sensitive (#11470)

    Signed-off-by: Cody Littley <[email protected]>
    Signed-off-by: Kelly Greco <[email protected]>
    Co-authored-by: Kelly Greco <[email protected]>

commit 08a23eb
Author: Nikita Lebedev <[email protected]>
Date:   Fri Feb 9 19:18:27 2024 +0200

    feat: Integrate Validations in HAPI tests (#10944)

    Signed-off-by: Nikita Lebedev <[email protected]>
    Signed-off-by: Matt Hess <[email protected]>
    Signed-off-by: Neeharika-Sompalli <[email protected]>
    Co-authored-by: Matt Hess <[email protected]>
    Co-authored-by: Neeharika-Sompalli <[email protected]>
    Co-authored-by: Neeharika Sompalli <[email protected]>

commit 3d27455
Author: Jendrik Johannes <[email protected]>
Date:   Fri Feb 9 17:39:58 2024 +0100

    build: re-enable running timing sensitive tests on CI (#11444)

    Signed-off-by: Jendrik Johannes <[email protected]>
    Co-authored-by: Kelly Greco <[email protected]>

commit 4f2e467
Author: Austin Littley <[email protected]>
Date:   Fri Feb 9 11:02:38 2024 -0500

    fix: Increase wait for squelch test assertion (#11461)

    Signed-off-by: Austin Littley <[email protected]>

commit ff4819a
Author: Michael Tinker <[email protected]>
Date:   Fri Feb 9 09:56:48 2024 -0600

    chore: migrate per node pending rewards (#11381)

    Signed-off-by: Michael Tinker <[email protected]>

commit f373ecb
Author: Lazar Petrovic <[email protected]>
Date:   Fri Feb 9 14:20:15 2024 +0100

    fix: SignedStateFileManagerTests  (#11468)

    Signed-off-by: Lazar Petrovic <[email protected]>

commit 9b8f850
Author: Iris Simon <[email protected]>
Date:   Fri Feb 9 08:11:48 2024 -0500

    fix: fixed diff test, ContractCall has status: CONSENSUS_GAS_EXHAUSTED (#11457)

    Signed-off-by: Iris Simon <[email protected]>
    Signed-off-by: Michael Tinker <[email protected]>
    Co-authored-by: Michael Tinker <[email protected]>

commit 3b85b7e
Author: Edward Wertz <[email protected]>
Date:   Thu Feb 8 15:58:31 2024 -0600

    refactor: EventSignatureValidator uses AncientMode (#11433)

    Signed-off-by: Edward Wertz <[email protected]>

commit ff59055
Author: Michael Heinrichs <[email protected]>
Date:   Thu Feb 8 21:57:13 2024 +0100

    fix: Fix service names for metrics (#11456)

    Signed-off-by: Michael Heinrichs <[email protected]>

commit 119fe64
Author: Cody Littley <[email protected]>
Date:   Thu Feb 8 13:41:21 2024 -0600

    refactor: gossip birth round (#11149)

    Signed-off-by: Cody Littley <[email protected]>

commit 8e6fc86
Author: artemananiev <[email protected]>
Date:   Thu Feb 8 10:43:30 2024 -0800

    fix: 11298: VirtualMapReconnectTest fails intermittently with path not in range log message (#11435)

    Reviewed-by: Anthony Petrov <[email protected]>, Ivan Malygin <[email protected]>
    Signed-off-by: Artem Ananev <[email protected]>

commit 2372290
Author: Nikolay Atanasow <[email protected]>
Date:   Thu Feb 8 19:18:51 2024 +0200

    fix: static call with selfdestruct to system account between 0.0.751 and 0.0.999 results in FAIL_INVALID (#11243)

    Signed-off-by: nikolay <[email protected]>

commit b5080b9
Author: Nikita Lebedev <[email protected]>
Date:   Thu Feb 8 19:18:27 2024 +0200

    fix: contracts.evm.allowCallsToNonContractAccounts flag misbehaviour (#11244)

    Signed-off-by: Nikita Lebedev <[email protected]>

commit cd5c2b7
Author: Ivan Malygin <[email protected]>
Date:   Thu Feb 8 12:14:45 2024 -0500

    fix: 11328 Optimized `DataFileReaderPbj.leaseFileChannel` method  (#11331)

    Signed-off-by: Ivan Malygin <[email protected]>

commit acaa4a1
Author: Ivan Ivanov <[email protected]>
Date:   Thu Feb 8 19:08:30 2024 +0200

    test: Create hapi tests for transfer and send operations for system accounts Part 1 (#11359)

    Signed-off-by: Ivan Ivanov <[email protected]>

commit c9e8586
Author: Austin Littley <[email protected]>
Date:   Thu Feb 8 12:03:19 2024 -0500

    feat: Check platform status before syncing (#11429)

    Signed-off-by: Austin Littley <[email protected]>

commit d2e1b6b
Author: Austin Littley <[email protected]>
Date:   Thu Feb 8 12:02:45 2024 -0500

    feat: Implement task scheduler squelching (#11398)

    Signed-off-by: Austin Littley <[email protected]>

commit 7801c39
Author: Thomas Moran <[email protected]>
Date:   Thu Feb 8 16:29:39 2024 +0000

    fix: 10904 Log catastrophic failures during ingest  (#11415)

    Signed-off-by: Thomas Moran <[email protected]>

commit 71c039e
Author: Lev Povolotsky <[email protected]>
Date:   Thu Feb 8 11:13:27 2024 -0500

    fix: transaction fee in record for mono code (#11434)

    Signed-off-by: Lev Povolotsky <[email protected]>

commit 581be44
Author: Edward Wertz <[email protected]>
Date:   Thu Feb 8 09:27:10 2024 -0600

    chore: move RandomAddressBookGenerator from swirlds-common to swirlds-platform-core (#11428)

    Signed-off-by: Edward Wertz <[email protected]>

commit e68ec56
Author: Georgi Lazarov <[email protected]>
Date:   Thu Feb 8 14:55:05 2024 +0200

    fix: revert changes from enabling fuzzy matching for TokenUpdatePrecompileSuite (#11419)

    Signed-off-by: georgi-l95 <[email protected]>

commit 77d207f
Author: Nikolay Atanasow <[email protected]>
Date:   Thu Feb 8 08:46:56 2024 +0200

    feat: address account nonce discrepancies mono (#11045)

    Signed-off-by: nikolay <[email protected]>
    Signed-off-by: Ivo Yankov <[email protected]>
    Co-authored-by: Ivo Yankov <[email protected]>

commit a71e2fb
Author: Maxi Tartaglia <[email protected]>
Date:   Wed Feb 7 17:41:56 2024 -0300

    fix: 11391adapting DurationGauge naming to conventions (#11416)

    Signed-off-by: mxtartaglia <[email protected]>

commit 60b9677
Author: Michael Heinrichs <[email protected]>
Date:   Wed Feb 7 21:22:42 2024 +0100

    fix: Fix generated metric names (#11423)

    Signed-off-by: Michael Heinrichs <[email protected]>

commit 5141ad3
Author: Michael Heinrichs <[email protected]>
Date:   Wed Feb 7 13:54:48 2024 +0100

    perf: Evaluate logging parameters only when needed (#11413)

    Signed-off-by: Michael Heinrichs <[email protected]>

commit ab5390d
Author: Michael Heinrichs <[email protected]>
Date:   Wed Feb 7 13:53:33 2024 +0100

    perf: Warm tokens as they are also on-disk now (#11412)

    Signed-off-by: Michael Heinrichs <[email protected]>

commit 93bd4e5
Author: Hendrik Ebbers <[email protected]>
Date:   Wed Feb 7 10:42:09 2024 +0100

    chore: Merkle test fixtures moved (#11382)

    Signed-off-by: Hendrik Ebbers <[email protected]>

commit 2258784
Author: Mustafa Uzun <[email protected]>
Date:   Wed Feb 7 09:04:51 2024 +0200

    fix: matching the signature for NonFungibleTokenInfo and FungibleTokenInfo on failure (#11133)

    Signed-off-by: Mustafa Uzun <[email protected]>

commit 0949d53
Author: Michael Tinker <[email protected]>
Date:   Tue Feb 6 14:42:24 2024 -0600

    chore: reload config from saved state (#11341)

    Signed-off-by: Michael Tinker <[email protected]>

commit 22a67b0
Author: Neeharika Sompalli <[email protected]>
Date:   Tue Feb 6 13:56:55 2024 -0600

    chore: Update protobuf version on develop (#11355)

    Signed-off-by: Neeharika-Sompalli <[email protected]>

commit 53bb6ce
Author: Michael Tinker <[email protected]>
Date:   Tue Feb 6 13:52:53 2024 -0600

    chore: add `-l` option to diff limited interval sizes (#11361)

    Signed-off-by: Michael Tinker <[email protected]>
    Signed-off-by: Iris Simon <[email protected]>
    Co-authored-by: Iris Simon <[email protected]>
    Co-authored-by: Iris Simon <[email protected]>

commit be761d1
Author: Michael Heinrichs <[email protected]>
Date:   Tue Feb 6 18:43:18 2024 +0100

    chore: Update PBJ dependency (#11397)

    Signed-off-by: Michael Heinrichs <[email protected]>

commit 00e33b1
Author: Petar Tonev <[email protected]>
Date:   Tue Feb 6 17:45:03 2024 +0200

    fix: token associations modular dumper (#11242)

commit 240d7b8
Author: Georgi Lazarov <[email protected]>
Date:   Tue Feb 6 17:40:03 2024 +0200

    feat: enable fuzzy record matching for `TokenUpdatePrecompileSuite` (#11008)

    Signed-off-by: georgi-l95 <[email protected]>

commit 4324340
Author: Austin Littley <[email protected]>
Date:   Tue Feb 6 08:48:03 2024 -0500

    fix: Modify where components look to indicate overloaded intake (#11369)

    Signed-off-by: Austin Littley <[email protected]>

commit 3cf9f8c
Author: JivkoKelchev <[email protected]>
Date:   Tue Feb 6 12:44:49 2024 +0700

    fix: 10315 halt on wrong token type (ERCPrecompileSuite fuzzy match) (#11164)

    Signed-off-by: Zhivko Kelchev <[email protected]>
    Signed-off-by: Valentin Tronkov <[email protected]>
    Signed-off-by: Michael Tinker <[email protected]>
    Co-authored-by: Valentin Tronkov <[email protected]>
    Co-authored-by: Michael Tinker <[email protected]>

commit 1c6c69f
Author: artemananiev <[email protected]>
Date:   Mon Feb 5 16:09:23 2024 -0800

    fix: 11298: VirtualMapReconnectTest fails intermittently with path not in range log message (#11370)

    Reviewed-by: Anthony Petrov <[email protected]>, Ivan Malygin <[email protected]>
    Signed-off-by: Artem Ananev <[email protected]>

commit c9ce0e8
Author: Matt Hess <[email protected]>
Date:   Mon Feb 5 15:23:21 2024 -0600

    fix: Return invalid token even if expected decimals are present (#11342)

    Signed-off-by: Matt Hess <[email protected]>

commit 6c654d9
Author: Kore Aguda <[email protected]>
Date:   Mon Feb 5 12:58:28 2024 -0600

    fix: broken unit test (#11233)

    Signed-off-by: Kore Aguda <[email protected]>

commit 9c1f467
Author: Austin Littley <[email protected]>
Date:   Mon Feb 5 12:01:11 2024 -0500

    feat: Migrate transaction handling to framework (#11144)

    Signed-off-by: Austin Littley <[email protected]>

commit eaca230
Author: Lazar Petrovic <[email protected]>
Date:   Mon Feb 5 17:49:40 2024 +0100

    chore: remove hashgraph demo (#11352)

    Signed-off-by: Lazar Petrovic <[email protected]>

commit bd1288f
Author: Kelly Greco <[email protected]>
Date:   Mon Feb 5 09:15:05 2024 -0600

    chore: Add `orderedSolderTo` method to OutputWire (#11330)

    Signed-off-by: Kelly Greco <[email protected]>

commit 831f644
Author: Lazar Petrovic <[email protected]>
Date:   Mon Feb 5 11:07:51 2024 +0100

    chore: Create ISS detector component (#11075)

    Signed-off-by: Lazar Petrovic <[email protected]>

commit 8bda7b2
Author: artemananiev <[email protected]>
Date:   Fri Feb 2 20:16:05 2024 -0800

    fix: 11348: The fix for 11231 doesn't cover ParsedBucket (#11349)

    Fixes: #11348
    Reviewed-by: Oleg Mazurov <[email protected]>
    Signed-off-by: Artem Ananev <[email protected]>

commit 328d3dd
Author: lukelee-sl <[email protected]>
Date:   Fri Feb 2 15:20:54 2024 -0800

    feat: address cold read issue in ExtCodeHash operation (#11323)

    Signed-off-by: lukelee-sl <[email protected]>

commit 8b7a581
Author: Richard Bair <[email protected]>
Date:   Fri Feb 2 15:09:35 2024 -0800

    chore: Update throttles.json (#11339)

    Signed-off-by: Richard Bair <[email protected]>

commit 21b682e
Author: artemananiev <[email protected]>
Date:   Fri Feb 2 11:21:33 2024 -0800

    feat: 11231: Improved virtual node remover (#11268)

    Fixes: #11231
    Reviewed-by: Anthony Petrov <[email protected]>, Austin Littley <[email protected]>, Ivan Malygin <[email protected]>, Joseph Sinclair <[email protected]>, Oleg Mazurov <[email protected]>
    Signed-off-by: Artem Ananev <[email protected]>

commit ed3218f
Author: Neeharika Sompalli <[email protected]>
Date:   Fri Feb 2 11:37:53 2024 -0600

    chore: Fix Some other issues faced during differential testing for 15 min window (#11297)

    Signed-off-by: Matt Hess <[email protected]>
    Signed-off-by: Neeharika-Sompalli <[email protected]>
    Signed-off-by: Michael Tinker <[email protected]>
    Signed-off-by: Cody Littley <[email protected]>
    Signed-off-by: Iris Simon <[email protected]>
    Signed-off-by: Zhivko Kelchev <[email protected]>
    Signed-off-by: Lev Povolotsky <[email protected]>
    Co-authored-by: Matt Hess <[email protected]>
    Co-authored-by: Michael Tinker <[email protected]>
    Co-authored-by: Cody Littley <[email protected]>
    Co-authored-by: Iris Simon <[email protected]>
    Co-authored-by: Zhivko Kelchev <[email protected]>
    Co-authored-by: Lev Povolotsky <[email protected]>

commit 792f0e3
Author: Cody Littley <[email protected]>
Date:   Fri Feb 2 10:10:22 2024 -0600

    fix: rejected execution in wiring framework (#11293)

    Signed-off-by: Cody Littley <[email protected]>

commit b27b4f8
Author: Neeharika Sompalli <[email protected]>
Date:   Fri Feb 2 09:31:19 2024 -0600

    chore: fix the record mismatch for `prng` transactions (#11238)

    Signed-off-by: Matt Hess <[email protected]>
    Signed-off-by: Neeharika-Sompalli <[email protected]>
    Signed-off-by: Michael Tinker <[email protected]>
    Signed-off-by: Cody Littley <[email protected]>
    Signed-off-by: Iris Simon <[email protected]>
    Signed-off-by: Lev Povolotsky <[email protected]>
    Co-authored-by: Matt Hess <[email protected]>
    Co-authored-by: Michael Tinker <[email protected]>
    Co-authored-by: Cody Littley <[email protected]>
    Co-authored-by: Iris Simon <[email protected]>
    Co-authored-by: Lev Povolotsky <[email protected]>

commit 356d5be
Author: Cody Littley <[email protected]>
Date:   Fri Feb 2 08:18:13 2024 -0600

    chore: drop support for async hashing (#11319)

    Signed-off-by: Cody Littley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@stoqnkpL stoqnkpL stoqnkpL left review comments

@rbair23 rbair23 Awaiting requested review from rbair23

@Neeharika-Sompalli Neeharika-Sompalli Awaiting requested review from Neeharika-Sompalli

@lukelee-sl lukelee-sl Awaiting requested review from lukelee-sl

@david-bakin-sl david-bakin-sl Awaiting requested review from david-bakin-sl

Assignees

@natanasow natanasow

Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@natanasow @tinker-michaelj @codecov-commenter @stoqnkpL @mustafauzunn @Ivo-Yankov